Messages in this thread Patch in this message | | | Date | Sun, 10 May 2009 11:45:04 -0400 (EDT) | From | "Robert P. J. Day" <> | Subject | [PATCH] SCRIPTS: Correct RE in header CONFIG leak check. |
| |
Correct the regular expression in scripts/headers_check.pl to include '_' as a valid character in the class; otherwise, the check will report a "leaked" symbol of CONFIG_A_B_C as merely CONFIG_A.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl index 56f90a4..4414c43 100644 --- a/scripts/headers_check.pl +++ b/scripts/headers_check.pl @@ -70,7 +70,7 @@ sub check_prototypes
sub check_config { - if ($line =~ m/[^a-zA-Z0-9_]+CONFIG_([a-zA-Z0-9]+)[^a-zA-Z0-9]/) { + if ($line =~ m/[^a-zA-Z0-9_]+CONFIG_([a-zA-Z0-9_]+)[^a-zA-Z0-9_]/) { printf STDERR "$filename:$lineno: leaks CONFIG_$1 to userspace where it is not valid\n"; } } ======================================================================== Robert P. J. Day Waterloo, Ontario, CANADA Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca Linked In: http://www.linkedin.com/in/rpjday Twitter: http://twitter.com/rpjday ========================================================================
| |