lkml.org 
[lkml]   [2009]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 17/27] add generic lib/checksum.c
    Arnd Bergmann wrote:
    > On Friday 01 May 2009, Russell King wrote:
    >> Since when has 'memcpy' been valid from user addresses?
    >
    > It's an artifact from the microblaze code, I found it after
    > submitting the patches when running sparse over it (yes, I
    > know I should do these things in a different order).
    >
    > The s390 version seems to get this right, so I'll use this:
    >
    > static inline __wsum
    > csum_partial_copy_from_user(const void __user *src, void *dst,
    > int len, __wsum sum,
    > int *err_ptr)
    > {
    > int missing;
    >
    > missing = copy_from_user(dst, src, len);
    > if (missing) {
    > memset(dst + len - missing, 0, missing);
    > *err_ptr = -EFAULT;
    > }
    >
    > return csum_partial(dst, len, sum);
    > }
    >
    > On microblaze, the old code was only correct for NOMMU.

    Not it wasn't there were address space problem too.

    Michal

    >
    > Thanks,
    >
    > Arnd <><


    --
    Michal Simek, Ing. (M.Eng)
    w: www.monstr.eu p: +42-0-721842854


    \
     
     \ /
      Last update: 2009-05-01 11:39    [W:3.868 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site