lkml.org 
[lkml]   [2009]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] driver-core: devtmpfs - driver core maintained /dev tmpfs
    On Fri, May 1, 2009 at 21:26, Andrew Morton <akpm@linux-foundation.org> wrote:
    > On Fri, 1 May 2009 13:16:22 +0200
    > Kay Sievers <kay.sievers@vrfy.org> wrote:
    >
    >> On Fri, May 1, 2009 at 07:29, Andrew Morton <akpm@linux-foundation.org> wrote:
    >>
    >> > dev->type->nodename() might have failed due to -ENOMEM, in which case
    >> > it seems wrong to assume that it returned NULL for <whatever reason you
    >> > thought it might want to return NULL>.
    >> >
    >> > It's all a bit confused.
    >>
    >> This logic is only for providing a custom name hint. Only a few
    >> devices need that at all. If the allocation fails, the default name
    >> will be used, not the custom name.
    >
    > But that's bad, isn't it?  It means that the kernel will come up with
    > one name if the memory allocation succeeded, and a different name if
    > the allocation failed.

    Yeah, sure, it's bad. But I think we have pretty much lost anyway, if
    we run into oom at this stage.

    What should we do instead? If we, for some reason, can not get a
    possible custom name?

    Thanks,
    Kay
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-05-02 00:03    [W:0.026 / U:119.844 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site