Messages in this thread | | | Date | Fri, 10 Apr 2009 00:58:20 +0200 | From | Alessandro Zummo <> | Subject | Re: [PATCH] rtc: Make rtc_update_irq callable with irqs enabled |
| |
On Thu, 9 Apr 2009 15:39:21 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> > The rtc_update_irq() might be called with irqs enabled, if a interrupt > > handler was registered without IRQF_DISABLED. > > Why? What are the consequences of not merging the patch? Is it a > bugfix? If so, what are the user-visible effects of the bug?
rtc_update_irq() is called by a driver, and a driver is supposed to know when it's doing the call.
The driver can either use IRQF_DISABLED or disable the interrupts in some other ways.
I also suspect this is some legacy we are carrying on, so it's better to leave the decision on the interrupt handling to the driver itself.
Unless I'm missing something.
--
Best regards,
Alessandro Zummo, Tower Technologies - Torino, Italy
http://www.towertech.it
| |