lkml.org 
[lkml]   [2009]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] FRV: Move to arch/frv/include/asm/
    Linus Torvalds wrote:
    >
    > On Thu, 9 Apr 2009, David Howells wrote:
    >> I should've used:
    >>
    >> stg mail -diff-opts=-M
    >>
    >> it would appear. I wonder if this should be the default.
    >
    > Ahh. I've never used stg. It seems to have some bad defaults.
    >
    > Also, depending on exactly what "stg" does, it is entirely possible that
    > adding that
    >
    > [diff]
    > renames
    >
    > to your .gitconfig won't help: those kinds of default configuration values
    > are (very much on purpose) ignored for certain low-level git commands,
    > exactly so that you can do reliable scripting without having to worry
    > about some user-specific config files.
    >
    >> Note that
    >>
    >> git-diff -M HEAD^ HEAD
    >>
    >> does not make output that looks like yours. It's missing the:
    >>
    >> {include/asm-frv => arch/frv/include/asm}/Kbuild | 0
    >> {include/asm-frv => arch/frv/include/asm}/atomic.h | 0
    >
    > Those come from "--summary", which summarizes file creation, deletion and
    > movement. Almost always combined with "--stat", but apparently the
    > "--stat" part is again in that "stg mail" script.

    David: Documentation/SubmittingPatches:/git diff/ =>

    'Please use "git diff -M --stat --summary" to generate the diffstat:
    the -M enables rename detection, and the summary enables a summary of
    new/deleted or renamed files.'

    --
    ~Randy


    \
     
     \ /
      Last update: 2009-04-09 23:29    [W:0.022 / U:32.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site