Messages in this thread Patch in this message | | | Subject | Re: [PATCH -tip] x86: ftrace.c declare prepare_ftrace_return before they get used | From | Jaswinder Singh Rajput <> | Date | Thu, 09 Apr 2009 23:11:55 +0530 |
| |
On Thu, 2009-04-09 at 19:20 +0200, Frederic Weisbecker wrote: > On Thu, Apr 09, 2009 at 10:07:48PM +0530, Jaswinder Singh Rajput wrote: > > Impact: fix sparse warning: > > arch/x86/kernel/ftrace.c:411:6: warning: symbol 'prepare_ftrace_return' was not declared. Should it be static? > > > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> > > --- > > arch/x86/include/asm/ftrace.h | 6 ++++++ > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > > diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h > > index bd2c651..49616d4 100644 > > --- a/arch/x86/include/asm/ftrace.h > > +++ b/arch/x86/include/asm/ftrace.h > > @@ -62,4 +62,10 @@ struct dyn_arch_ftrace { > > #endif /* __ASSEMBLY__ */ > > #endif /* CONFIG_FUNCTION_TRACER */ > > > > +#ifdef CONFIG_FUNCTION_GRAPH_TRACER > > +#ifndef __ASSEMBLY__ > > +extern void prepare_ftrace_return(unsigned long *, unsigned long); > > > But it is only used from asm code so there is no need to make > its prototype public. > > I don't think this is necessary but if you really think it is, then I would prefer > you use the already existing #ifndef __ASSEMBLY__ block. >
Like this:
Subject: [PATCH] x86: ftrace.c declare prepare_ftrace_return before they get used
Impact: fix sparse warning: arch/x86/kernel/ftrace.c:411:6: warning: symbol 'prepare_ftrace_return' was not declared. Should it be static?
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> --- arch/x86/include/asm/ftrace.h | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h index bd2c651..ddc9236 100644 --- a/arch/x86/include/asm/ftrace.h +++ b/arch/x86/include/asm/ftrace.h @@ -59,6 +59,11 @@ struct dyn_arch_ftrace { }; #endif /* CONFIG_DYNAMIC_FTRACE */ + +#ifdef CONFIG_FUNCTION_GRAPH_TRACER +extern void prepare_ftrace_return(unsigned long *, unsigned long); +#endif + #endif /* __ASSEMBLY__ */ #endif /* CONFIG_FUNCTION_TRACER */ -- 1.6.0.6
| |