lkml.org 
[lkml]   [2009]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86,edac: fix for compiler error in traps.c

Andrew, I guess this change is not needed. Ingo was correct, there must
have been something wrong with my build environment. Not sure what
happened, but I had this failure right after updating my git repo. I did
not do a make clean, so my build environment was not pristine. After doing
a make clean, I no longer have this error.

Sorry for the noise.

-- Steve



On Wed, 8 Apr 2009, Andrew Morton wrote:

> On Wed, 8 Apr 2009 20:06:53 -0400 (EDT) Steven Rostedt <rostedt@goodmis.org> wrote:
>
> >
> > Impact: compile fix
> >
> > I got this compile failure on both tip/tracing/core as well as on
> > v2.6.30-rc1.
> >
> > LD .tmp_vmlinux1
> > arch/x86/kernel/built-in.o: In function `do_nmi':
> > (.text+0x3c18): undefined reference to `edac_handler_set'
> > arch/x86/kernel/built-in.o: In function `do_nmi':
> > (.text+0x3c48): undefined reference to `edac_atomic_assert_error'
> > make: *** [.tmp_vmlinux1] Error 1
> > [root@bxrhel51 linux-trace.git]# grep edac_handler_set
> > [root@bxrhel51 linux-trace.git]# Grep edac_handler_set '*.[ch]'
> > find . -name "*.[ch]" ! -type d | xargs grep "edac_handler_set"
> > ./arch/x86/kernel/traps.c: if (edac_handler_set()) {
> > ./include/linux/edac.h:extern int edac_handler_set(void);
> > ./drivers/edac/edac_stub.c:int edac_handler_set(void)
> > ./drivers/edac/edac_stub.c:EXPORT_SYMBOL_GPL(edac_handler_set);
> >
> > This patch seems to fix it.
> >
> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> >
> > diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile
> > index a5fdcf0..cc2bcb4 100644
> > --- a/drivers/edac/Makefile
> > +++ b/drivers/edac/Makefile
> > @@ -7,7 +7,7 @@
> > #
> >
> >
> > -obj-$(CONFIG_EDAC) := edac_stub.o
> > +obj-$(CONFIG_EDAC) += edac_stub.o
> > obj-$(CONFIG_EDAC_MM_EDAC) += edac_core.o
> >
> > edac_core-objs := edac_mc.o edac_device.o edac_mc_sysfs.o edac_pci_sysfs.o
>
> OK, thanks, I'll send that Linuswards asap.
>
> I guess it could/should be
>
> obj-y += edac_stub.o
>
> because CONFIG_EDAC is known to be true in drivers/edac/. But that's
> just a consistency/style thing for Doug to scratch his head over ;)
>


\
 
 \ /
  Last update: 2009-04-09 17:11    [W:0.193 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site