Messages in this thread | | | Date | Wed, 08 Apr 2009 02:33:41 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH 2/2 resend] libata-sff: avoid byte swapping in ata_sff_data_xfer() |
| |
Sergei Shtylyov wrote: > Handling of the trailing byte in ata_sff_data_xfer() is suboptimal bacause: > > - it always initializes the padding buffer to 0 which is not really needed in > both the read and write cases; > > - it has to use memcpy() to transfer a single byte from/to the padding buffer; > > - it uses io{read|write}16() accessors which swap bytes on the big endian CPUs > and so have to additionally convert the data from/to the little endian format > instead of using io{read|write}16_rep() accessors which are not supposed to > change the byte ordering. > > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
applied
| |