lkml.org 
[lkml]   [2009]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ptrace: checkpatch fixes


    On Wed, 8 Apr 2009, Christian Borntraeger wrote:
    >
    > Isnt checkpatch just following what is written down in the Documentation
    > folder? Maybe adopting the following part of CodingStyle and add more
    > examples for good and bad would give the checkpatch authors a better
    > idea about your intent.

    The thing is, it's true that it's good if things fit in 80 columns.

    But _splitting_ lines isn't the answer. Making code simpler is, but
    somehow the 80-column warning never causes that to happen - instead people
    just split.

    And yes, I guess we should remove the language saying so. It's not from
    my original coding stule, it was added later by others, and came through
    Andrew (commit 560362dafe4de60db70f2c298a53f4613453a78b: "[PATCH]
    Codingstyle update" in the historical Linux archive).

    Linus


    \
     
     \ /
      Last update: 2009-04-08 22:49    [W:2.469 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site