lkml.org 
[lkml]   [2009]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] block_write_full_page: switch synchronous writes to use WRITE_SYNC_PLUG
    On Wed, Apr 08, 2009 at 08:00:33AM +0200, Jens Axboe wrote:
    >
    > I think you should comment on why we don't need to do the actual unplug.
    > See what I added in fs/jbd/commit.c:journal_commit_transaction():
    >
    > /*
    > * Use plugged writes here, since we want to submit several
    > * before we unplug the device. We don't do explicit
    > * unplugging in here, instead we rely on sync_buffer() doing
    > * the unplug for us.
    > */

    OK, agreed. I'll add a comment explaining what is going on in the
    patch; better there than in the commit log.

    - Ted


    \
     
     \ /
      Last update: 2009-04-08 17:33    [W:0.022 / U:2.240 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site