lkml.org 
[lkml]   [2009]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 54/56] x86: Remove void casts

* Jack Stone <jwjstone@fastmail.fm> wrote:

> Ingo Molnar wrote:
> > * Jack Stone <jwjstone@fastmail.fm> wrote:
> >
> >
> >> Ingo Molnar wrote:
> >>
> >>> * Jack Stone <jwjstone@fastmail.fm> wrote:
> >>>
> >>>
> >>>
> >>>> Fixed patch
> >>>>
> >>>> Thanks,
> >>>>
> >>>>
> >>> Hm, what was fixed?
> >>>
> >>>
> >> I removed casts on pointer arithmetic which probably still needed to be
> >> there to do the arithmetic properly.
> >>
> >
> > ... which pretty much proves the point that these patches should
> > not go via any "trivial" tree.
> >
> > Those additions of mmu pointers you did were outright lethal, i
> > doubt this stuff could have booted on both 32-bit and 64-bit
> > x86.
> >
> > Please dont do this. Or if you do, please double check your
> > change and double check that the relevant vmlinux disassembly is
> > still bit for bit the same.
> >
>
> Thats what I meant by fixed - those changes were removed from the
> patch.

No, i mean, this approach should be changed, and i dont think any
type cast change should go via any trivial tree. It's easy to mess
it up. Please submit them to the maintainer trees.

Ingo


\
 
 \ /
  Last update: 2009-04-08 16:51    [W:0.443 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site