lkml.org 
[lkml]   [2009]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 05/56] block: Remove void casts
From
On Wed, Apr 8, 2009 at 13:38, Jack Stone <jwjstone@fastmail.fm> wrote:
> Bert Wesarg wrote:
>> Could you feed the patches through checkpatch.pl to find and fix these
>> style issues.
>>
>> (...)
>>
>> If typeof(c) == CommandList_struct*, that you could replace
>> sizeof(CommandList_struct) with sizeof(*c) to make the expression
>> shorter and fit into one line.
>>
> I was trying to avoid any changes beyond removing the void casts.
>
> I can go through and fix all these if people don't think thats too much to
> review in one go.
Right, thats a balancing act, and I think this change could be too much.

>
> I'll fix the line issues you've flagged up and resend the affected patched.
>

Bert
> Thanks,
>
> Jack
>


\
 
 \ /
  Last update: 2009-04-08 14:07    [W:0.501 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site