| Date | Wed, 08 Apr 2009 12:38:53 +0100 | From | Jack Stone <> | Subject | Re: [PATCH 05/56] block: Remove void casts |
| |
Bert Wesarg wrote: > Could you feed the patches through checkpatch.pl to find and fix these > style issues. > > (...) > > If typeof(c) == CommandList_struct*, that you could replace > sizeof(CommandList_struct) with sizeof(*c) to make the expression > shorter and fit into one line. > I was trying to avoid any changes beyond removing the void casts.
I can go through and fix all these if people don't think thats too much to review in one go.
I'll fix the line issues you've flagged up and resend the affected patched.
Thanks,
Jack
|