Messages in this thread | | | Date | Wed, 8 Apr 2009 10:57:15 +0530 | From | Balbir Singh <> | Subject | Re: [PATCH] memcg remove warning at DEBUG_VM=off |
| |
* KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2009-04-08 14:20:42]:
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > This is against 2.6.30-rc1. (maybe no problem against mmotm.) > > == > Fix warning as > > CC mm/memcontrol.o > mm/memcontrol.c:318: warning: ?$B!Fmem_cgroup_is_obsolete?$B!G defined but not used > > This is called only from VM_BUG_ON(). > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > --- > Index: linux-2.6.30-rc1/mm/memcontrol.c > =================================================================== > --- linux-2.6.30-rc1.orig/mm/memcontrol.c > +++ linux-2.6.30-rc1/mm/memcontrol.c > @@ -314,13 +314,14 @@ static struct mem_cgroup *try_get_mem_cg > return mem; > } > > +#ifdef CONFIG_DEBUG_VM > static bool mem_cgroup_is_obsolete(struct mem_cgroup *mem) > { > if (!mem) > return true; > return css_is_removed(&mem->css); > } > - > +#endif
Can we change the code to use
VM_BUG_ON(!mem || css_is_removed(&mem->css));
Reviewed-by: Balbir Singh <balbir@linux.vnet.ibm.com>
-- Balbir
| |