lkml.org 
[lkml]   [2009]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] Avoid putting a bad page back on the LRU
Date
Hi Russ,

On Wednesday 08 April 2009, Russ Anderson wrote:
> --- linux-next.orig/mm/migrate.c 2009-04-07 18:32:12.781949840 -0500
> +++ linux-next/mm/migrate.c 2009-04-07 18:34:19.169736260 -0500
> @@ -693,6 +696,26 @@ unlock:
> * restored.
> */
> list_del(&page->lru);
> +#ifdef CONFIG_MEMORY_FAILURE
> + if (PagePoison(page)) {
> + if (rc == 0)
> + /*
> + * A page with a memory error that has
> + * been migrated will not be moved to
> + * the LRU.
> + */
> + goto move_newpage;
> + else
> + /*
> + * The page failed to migrate and will not
> + * be added to the bad page list. Clearing
> + * the error bit will allow another attempt
> + * to migrate if it gets another correctable
> + * error.
> + */
> + ClearPagePoison(page);

Clearing the flag doesn't change the fact, that this page is representing
permanently bad RAM.

What about removing it from the LRU and adding it to a bad RAM list in every case?
After hot swapping the physical RAM banks it could be moved back, not before.


Best Regards

Ingo Oeser


\
 
 \ /
  Last update: 2009-04-08 05:45    [W:1.567 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site