Messages in this thread | | | Date | Tue, 7 Apr 2009 17:31:57 -0400 (EDT) | From | Christoph Lameter <> | Subject | Re: [patch] slub: default min_partial to at least highest cpus per node |
| |
On Tue, 7 Apr 2009, Pekka Enberg wrote:
> Christoph Lameter wrote: > > I am not sure about the benefit of this. If the page allocator finally > > improves in performance then we can reduce the mininum number of partial > > slabs kept and also do pass through for all sizes >2k. > > Sure, we can do that, but it still makes sense to adjust the partial list > sizes based on per-node CPU count. So I'm inclined to apply the patch I > suggested if it shows performance gains on one or more of the relevant > benchmarks (sysbench, tbench, hackbench, netperf, etc.).
The partial list sizes cannot be adjusted. There is just a mininum size that is set via MIN_PARTIAL. Currently we use that to avoid trips to the page allocator by keeping the list artificially long. This should not be done because it increases memory overhead by keeping slab pages around with no objects. If the page allocator trips are not that expensive anymore then there is no reason to keep these slab pages around. A hot page can be reused by any other subsystemm in the kernel.
| |