lkml.org 
[lkml]   [2009]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 05/13] x86: use identical loop constructs in 32-bit and 64-bit native_init_IRQ()
    Date
    Impact: cleanup

    Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
    ---
    arch/x86/kernel/irqinit_32.c | 2 +-
    arch/x86/kernel/irqinit_64.c | 9 +++++----
    2 files changed, 6 insertions(+), 5 deletions(-)

    diff --git a/arch/x86/kernel/irqinit_32.c b/arch/x86/kernel/irqinit_32.c
    index 9ba68c4..1029a18 100644
    --- a/arch/x86/kernel/irqinit_32.c
    +++ b/arch/x86/kernel/irqinit_32.c
    @@ -205,7 +205,7 @@ void __init native_init_IRQ(void)
    * us. (some of these will be overridden and become
    * 'special' SMP interrupts)
    */
    - for (i = FIRST_EXTERNAL_VECTOR; i < NR_VECTORS; i++) {
    + for (i = FIRST_EXTERNAL_VECTOR; i < NR_VECTORS; i++) {
    /* SYSCALL_VECTOR was reserved in trap_init. */
    if (i != SYSCALL_VECTOR)
    set_intr_gate(i, interrupt[i-FIRST_EXTERNAL_VECTOR]);
    diff --git a/arch/x86/kernel/irqinit_64.c b/arch/x86/kernel/irqinit_64.c
    index 8cd1053..1c8858b 100644
    --- a/arch/x86/kernel/irqinit_64.c
    +++ b/arch/x86/kernel/irqinit_64.c
    @@ -159,15 +159,16 @@ void __init native_init_IRQ(void)
    int i;

    init_ISA_irqs();
    +
    /*
    * Cover the whole vector space, no vector can escape
    * us. (some of these will be overridden and become
    * 'special' SMP interrupts)
    */
    - for (i = 0; i < (NR_VECTORS - FIRST_EXTERNAL_VECTOR); i++) {
    - int vector = FIRST_EXTERNAL_VECTOR + i;
    - if (vector != IA32_SYSCALL_VECTOR)
    - set_intr_gate(vector, interrupt[i]);
    + for (i = FIRST_EXTERNAL_VECTOR; i < NR_VECTORS; i++) {
    + /* IA32_SYSCALL_VECTOR was reserved in trap_init. */
    + if (i != IA32_SYSCALL_VECTOR)
    + set_intr_gate(i, interrupt[i-FIRST_EXTERNAL_VECTOR]);
    }

    apic_intr_init();
    --
    1.5.6.3


    \
     
     \ /
      Last update: 2009-04-07 17:09    [W:0.020 / U:0.376 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site