Messages in this thread Patch in this message | | | Date | Sun, 05 Apr 2009 14:29:57 +0200 | From | Eric Dumazet <> | Subject | [PATCH] netfilter: ip6tables fix |
| |
Eric Dumazet a écrit : > Graham Murray a écrit : >> iptables gives me no problems at all, it is just ip6tables that >> fails. The first indication of this is during the init scripts when >> ip6tables-restore fails. > > I see, its a plain bug in net/ipv6/netfilter/ip6_tables.c > function alloc_counters() always returns -ENOMEM > > Unfortunatly , its Sunday here and I have to run for lunch time with family :) > > If nobody beats me, I will do the fix in a couple of hours...
Here is the fix, thanks Graham for the report !
[PATCH] netfilter: ip6tables fix
ip6_tables.c alloc_counters() misses a return statement, making ip6tables -N always failing and leaking memory.
Reported-by: Graham Murray <graham@gmurray.org.uk> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com> ---
diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c index dfed176..800ae85 100644 --- a/net/ipv6/netfilter/ip6_tables.c +++ b/net/ipv6/netfilter/ip6_tables.c @@ -1033,6 +1033,8 @@ static struct xt_counters *alloc_counters(struct xt_table *table) xt_free_table_info(info); + return counters; + free_counters: vfree(counters); nomem: -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |