lkml.org 
[lkml]   [2009]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/7] kconfig: enable CONFIG_IKCONFIG from streamline_config.pl

On Thu, 30 Apr 2009, Alan Jenkins wrote:
> > +
> > + if (/CONFIG_IKCONFIG/) {
> > + if (/# CONFIG_IKCONFIG is not set/) {
> > + # enable IKCONFIG at least as a module
> > + print "CONFIG_IKCONFIG=m\n";
> > + # don't ask about PROC
> > + print "# CONFIG_IKCONFIG is not set\n";
>
> I assume the second one should be CONFIG_IKCONFIG_PROC :-).

Ag! Thanks!

>
> > + } else {
> > + print;
> > + }
> > + next;
> > + }
> > +
> > + if (/^(CONFIG.*)=(m|y)/) {
> > + if (defined($configs{$1})) {
> > + $setconfigs{$1} = $2;
> > + print;
> > + } elsif ($2 eq "m") {
> > + print "# $1 is not set\n";
> > } else {
> > - print;
> > + print;
> > }
>
> > + } else {
> > + print;
> > + }
>
>
> Maybe it would be cleaner make the two "if" blocks the same; i.e. do
> this instead:

Yeah, that does look cleaner.

-- Steve

>
> + next;
> + }
> +
> + print;
>
>
> > }
> > close(CIN);
> >
>


\
 
 \ /
  Last update: 2009-05-01 00:55    [W:0.035 / U:0.820 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site