lkml.org 
[lkml]   [2009]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: ptrace: selinux_bprm_committed_creds: simplify __wake_up_parent() code and s/parent/real_parent/
Date
> Afaics, with this patch the only user of ->parent outside of ptrace.c & co
> is arch/ia64/kernel/mca.c:format_mca_init_stack(). Hopefully ->parent will
> die soon.

Woo! Nice work. That oddball ia64 case is obviously trivial, it just
wants to avoid uninitialized stuff in its task_struct for a
not-really-a-process. With your fixes, it seems certain that ->parent
should never be examined in those tasks. Even so, the extra initialization
doesn't hurt. You could clean it up today with:
tracehook_finish_clone(p, 0, 0);
at the end (in place of touching ->parent).
That will dtrt both now and later.


Thanks,
Roland


\
 
 \ /
  Last update: 2009-05-01 00:47    [W:0.084 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site