lkml.org 
[lkml]   [2009]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] USB: Provide USB boot device availability notification
    On Thu, 30 Apr 2009, Sergei Shtylyov wrote:

    > > +/* The mask of possible USB boot devices depends on what drivers and
    > > + * options have been configured into the kernel. There are too many
    > > + * USB network config options to list here, so just assume it is always
    > > + * possible to have a USB network device.
    > > + */
    > > +static int usb_bootdev_mask = 0
    > > +#ifdef CONFIG_USB_SERIAL_CONSOLE
    > > + | BOOTDEV_CONSOLE_MASK
    > > +#endif
    > > +#if defined(CONFIG_USB_STORAGE) | defined(CONFIG_BLK_DEV_UB)
    >
    > It should be ||, not bitwise | here, no?

    No, it should be bitwise |. The value being constructed is a union of
    disjoint mask bits.

    Alan Stern



    \
     
     \ /
      Last update: 2009-04-30 17:35    [W:0.017 / U:1.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site