lkml.org 
[lkml]   [2009]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/14] NFSv4: Add label recommended attribute and NFSv4 flags
    On Wed, 26 Nov 2008, David P. Quigley wrote:

    > diff --git a/include/linux/nfs4.h b/include/linux/nfs4.h
    > index ea03667..144eacf 100644
    > --- a/include/linux/nfs4.h
    > +++ b/include/linux/nfs4.h
    > @@ -21,6 +21,7 @@
    > #define NFS4_FHSIZE 128
    > #define NFS4_MAXPATHLEN PATH_MAX
    > #define NFS4_MAXNAMLEN NAME_MAX
    > +#define NFS4_MAXLABELLEN 4096

    I can't recall if this has been discussed before, but why is the label
    length limited to this value?

    SELinux on-disk labels can be up to 64KB in size (XATTR_SIZE_MAX), and I'd
    like to ensure that we don't end up with an unnecessary disk vs. network
    label size incompatibility.

    While it seems unlikely that SELinux (and other forms of MAC) security
    labels would currently exceed 4K, we don't know how SELinux might be
    extended in the future, and should avoid limiting label flexibility
    beyond existing constraints.


    - James
    --
    James Morris
    <jmorris@namei.org>


    \
     
     \ /
      Last update: 2009-04-03 10:35    [W:3.929 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site