Messages in this thread Patch in this message | | | From | "Han, Weidong" <> | Date | Sat, 4 Apr 2009 11:37:56 +0800 | Subject | RE: [patch 2/2] x2apic/intr-remap: decouple interrupt remapping from x2apic |
| |
Siddha, Suresh B wrote: > On Fri, 2009-04-03 at 02:15 -0700, Han, Weidong wrote: >> >> -#ifdef CONFIG_INTR_REMAP >> +#ifdef CONFIG_X86_X2APIC > > Weidong, Can we also fix these config options? > > Today, selecting CONFIG_INTR_REMAP automatically selects > CONFIG_X86_X2APIC. It should be the other way round. > > i.e., turning on CONFIG_X86_X2APIC should automatically enable > CONFIG_INTR_REMAP and just enabling CONFIG_INTR_REMAP shouldn't enable > CONFIG_X86_X2APIC. > > Also please make sure that the code compiles (and works :)) in > different combinations of these config settings.
Thanks for your reminder. Following patch changes the config options selection. The code can compiles in different combinations.
Subject: [PATCH] Change X2APIC and INTR_REMAP config selection
Currently, selecting CONFIG_INTR_REMAP automatically selects CONFIG_X86_X2APIC. It should be the other way round. i.e. selecting CONFIG_X86_X2APIC automatically enables CONFIG_INTR_REMAP, but selecting CONFIG_INTR_REMAP won't enable CONFIG_X86_X2APIC.
Signed-off-by: Weidong Han <weidong.han@intel.com> --- arch/x86/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 5696cec..0e522a4 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -251,6 +251,7 @@ config SMP config X86_X2APIC bool "Support x2apic" depends on X86_LOCAL_APIC && X86_64 + select INTR_REMAP ---help--- This enables x2apic support on CPUs that have this feature. @@ -1879,7 +1880,6 @@ config DMAR_FLOPPY_WA config INTR_REMAP bool "Support for Interrupt Remapping (EXPERIMENTAL)" depends on X86_64 && X86_IO_APIC && PCI_MSI && ACPI && EXPERIMENTAL - select X86_X2APIC ---help--- Supports Interrupt remapping for IO-APIC and MSI devices. To use x2apic mode in the CPU's which support x2APIC enhancements or -- 1.6.0.4
| |