lkml.org 
[lkml]   [2009]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] virtio: add missing include to virtio_net.h
    On Wed, Apr 29, 2009 at 6:49 PM, David Miller <davem@davemloft.net> wrote:
    > From: Grant Likely <grant.likely@secretlab.ca>
    > Date: Tue, 28 Apr 2009 09:46:54 -0600
    >
    > [ Grant, please CC: netdev on networking patches, thanks. ]

    Oops, sorry about that; I had in my head "virtio" and it didn't even
    occur to me that it was also netdev. :-)

    g.

    >
    >> virtio_net.h uses the macro ETH_ALEN which is defined in linux/if_ether.h.
    >> Discovered when hacking on virtio-over-pci patches.
    >>
    >> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
    >
    > Rusty, ACK?
    >
    > I haven't been able to get responses from Rusty on virtio net
    > patches, so if he doesn't start responding soon I'm going to
    > integrates the fixes I've seen lately as they all look
    > reasonable to me.
    >
    >> ---
    >>
    >>  include/linux/virtio_net.h |    1 +
    >>  1 files changed, 1 insertions(+), 0 deletions(-)
    >>
    >>
    >> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h
    >> index 242348b..cec79ad 100644
    >> --- a/include/linux/virtio_net.h
    >> +++ b/include/linux/virtio_net.h
    >> @@ -4,6 +4,7 @@
    >>   * compatible drivers/servers. */
    >>  #include <linux/types.h>
    >>  #include <linux/virtio_config.h>
    >> +#include <linux/if_ether.h>
    >>
    >>  /* The ID for virtio_net */
    >>  #define VIRTIO_ID_NET        1
    >>
    >> --
    >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    >> the body of a message to majordomo@vger.kernel.org
    >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
    >> Please read the FAQ at  http://www.tux.org/lkml/
    >



    --
    Grant Likely, B.Sc., P.Eng.
    Secret Lab Technologies Ltd.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-04-30 03:23    [W:0.027 / U:1.384 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site