lkml.org 
[lkml]   [2009]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 13/19] tracing/workqueue: use list_for_each_entry instead of list_for_each_entry_safe in probe_workqueue_destruction()
    Date
    From: Zhaolei <zhaolei@cn.fujitsu.com>

    No need to use list_for_each_entry_safe() because we just remove one list node
    which is first found in list iteration.
    (we don't continue list iteration after remove list node)

    [ Impact: cleanup ]

    Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Tom Zanussi <tzanussi@gmail.com>
    Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    ---
    kernel/trace/trace_workqueue.c | 5 ++---
    1 files changed, 2 insertions(+), 3 deletions(-)

    diff --git a/kernel/trace/trace_workqueue.c b/kernel/trace/trace_workqueue.c
    index 51ed57e..b995bc0 100644
    --- a/kernel/trace/trace_workqueue.c
    +++ b/kernel/trace/trace_workqueue.c
    @@ -206,12 +206,11 @@ static void probe_workqueue_destruction(struct task_struct *wq_thread)
    {
    /* Workqueue only execute on one cpu */
    int cpu = cpumask_first(&wq_thread->cpus_allowed);
    - struct cpu_workqueue_stats *node, *next;
    + struct cpu_workqueue_stats *node;
    unsigned long flags;

    spin_lock_irqsave(&workqueue_cpu_stat(cpu)->lock, flags);
    - list_for_each_entry_safe(node, next, &workqueue_cpu_stat(cpu)->list,
    - list) {
    + list_for_each_entry(node, &workqueue_cpu_stat(cpu)->list, list) {
    struct workfunc_stats *wfstat, *wfstatnext;

    if (node->task != wq_thread)
    --
    1.6.2.3


    \
     
     \ /
      Last update: 2009-04-30 02:37    [W:0.022 / U:64.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site