[lkml]   [2009]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[patch 13/58] bridge: bad error handling when adding invalid ether address
    2.6.27-stable review patch.  If anyone has any objections, please let us know.


    From: Stephen Hemminger <>

    [ Upstream commit cda6d377ec6b2ee2e58d563d0bd7eb313e0165df ]

    This fixes an crash when empty bond device is added to a bridge.
    If an interface with invalid ethernet address (all zero) is added
    to a bridge, then bridge code detects it when setting up the forward
    databas entry. But the error unwind is broken, the bridge port object
    can get freed twice: once when ref count went to zeo, and once by kfree.
    Since object is never really accessible, just free it.

    Signed-off-by: Stephen Hemminger <>
    Signed-off-by: David S. Miller <>
    Signed-off-by: Greg Kroah-Hartman <>

    net/bridge/br_if.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/net/bridge/br_if.c
    +++ b/net/bridge/br_if.c
    @@ -419,7 +419,6 @@ err2:
    - kobject_put(&p->kobj);
    dev_set_promiscuity(dev, -1);

     \ /
      Last update: 2009-04-30 00:31    [W:0.018 / U:11.932 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site