lkml.org 
[lkml]   [2009]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/21] x86: add methods for writing of an MSR on several CPUs
Borislav Petkov wrote:
> +}
> +
> +/* rdmsr on a bunch of cpus
> + *
> + * @mask: which cpus
> + * @msr_no: which MSR
> + * @l: array of the lower 32-bit MSR values
> + * @h: array of the higher 32-bit MSR values
> + *

Urk!

Please, for the love of God, no!

Make it an array of u64s or (equivalently!) an array of (l,h)
structures, not separate arrays for the halves of the register.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2009-04-29 19:43    [from the cache]
©2003-2011 Jasper Spaans