Messages in this thread | | | Subject | Re: [PATCH 04/29] x86/perfcounters: rework pmc_amd_save_disable_all() and pmc_amd_restore_all() | From | Peter Zijlstra <> | Date | Wed, 29 Apr 2009 13:27:46 +0200 |
| |
On Wed, 2009-04-29 at 13:19 +0200, Ingo Molnar wrote: > * Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> > > disable-all was arguably a hack i introduced and which spread too > > > far. Can you see a conceptual need for it? > > > > power suffers the same issue and simply iterates the things like > > amd does now. > > > > The thing is, with a global disable you get slightly better > > coupling, so in that respect it might be nice to have. > > ok. With system-wide profiling there's no global disable/enable in > the fastpath. Do we have any of them in the per task counter > fastpath?
the scheduling bits seem to be littered with hw_perf_save_disable/restore, other than that I think the overflow interrupt used it.
| |