Messages in this thread Patch in this message | | | Date | Wed, 29 Apr 2009 00:48:16 -0400 | From | Steven Rostedt <> | Subject | [PATCH 2/5] tracing: fix ref count in splice pages |
| |
From: Steven Rostedt <srostedt@redhat.com>
The pages allocated for the splice binary buffer did not initialize the ref count correctly. This caused pages not to be freed and causes a drastic memory leak.
Thanks to logdev I was able to trace the tracer to find where the leak was.
[ Impact: stop memory leak when using splice ]
Signed-off-by: Steven Rostedt <rostedt@goodmis.org> --- kernel/trace/trace.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 5d704a4..9058240 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -3531,6 +3531,7 @@ tracing_buffers_splice_read(struct file *file, loff_t *ppos, if (!ref) break; + ref->ref = 1; ref->buffer = info->tr->buffer; ref->page = ring_buffer_alloc_read_page(ref->buffer); if (!ref->page) { -- 1.6.2.1 --
| |