lkml.org 
[lkml]   [2009]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/12] mutex: add atomic_dec_and_mutex_lock
On Mon, 27 Apr 2009 17:53:05 -0400
Eric Paris <eparis@redhat.com> wrote:

> Much like the atomic_dec_and_lock() function in which we take and hold a
> spin_lock if we drop the atomic to 0 this function takes and holds the
> mutex if we dec the atomic to 0.

I sucked these patches into -mm, mainly for a bit of compile-time and
runtime testing.

I read through them all on the previous iteration. IIRC my main
impression was that the code and the data structures were not
sufficiently well commented for that review to have been particularly
effective. Hopefully things improved there?

It would be good if Al and/or hch and/or others could review this work.
Christoph has indicated that he will be doing this.

You didn't reply to all my review comments from last time, but from a
quick random sample I see that some/most comments have been addressed.
Hopefully all were at least considered.

It's a little worrisome that my comment against this particular patch
was lost, and the patch was verbatim merged into Ingo's perfcounter
branch. Did anything else get lost?


\
 
 \ /
  Last update: 2009-04-28 22:39    [from the cache]
©2003-2011 Jasper Spaans