lkml.org 
[lkml]   [2009]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] x86: cleanup alternative.h
Ingo Molnar wrote:
>
> Please try to align both the continuation backslashes and the
> comments vertically. Something like:
>
>> +#define ALTERNATIVE(oldinstr, newinstr, feature) \
>> + \
>> + "661:\n\t" oldinstr "\n662:\n" \
>> + ".section .altinstructions,\"a\"\n" \
>> + _ASM_ALIGN "\n" \
>> + _ASM_PTR "661b\n" /* label */ \
>> + _ASM_PTR "663f\n" /* new instruction */ \
>> + " .byte " __stringify(feature) "\n" /* feature bit */ \
>> + " .byte 662b-661b\n" /* sourcelen */ \
>> + " .byte 664f-663f\n" /* replacementlen */ \
>
> ... should do the trick. (also note the extra line after the #define)
>

This formatting seems a bit odd; _ASM_ALIGN, _ASM_PTR, and .section are
functionally equivalent to the opcode field, as is .byte, so the shift
in indentation for the .byte lines seems odd at best.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2009-04-28 19:45    [W:0.069 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site