Messages in this thread | | | Date | Tue, 28 Apr 2009 10:40:09 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [GIT PULL] x86: cleanup alternative.h |
| |
Ingo Molnar wrote: > > Please try to align both the continuation backslashes and the > comments vertically. Something like: > >> +#define ALTERNATIVE(oldinstr, newinstr, feature) \ >> + \ >> + "661:\n\t" oldinstr "\n662:\n" \ >> + ".section .altinstructions,\"a\"\n" \ >> + _ASM_ALIGN "\n" \ >> + _ASM_PTR "661b\n" /* label */ \ >> + _ASM_PTR "663f\n" /* new instruction */ \ >> + " .byte " __stringify(feature) "\n" /* feature bit */ \ >> + " .byte 662b-661b\n" /* sourcelen */ \ >> + " .byte 664f-663f\n" /* replacementlen */ \ > > ... should do the trick. (also note the extra line after the #define) >
This formatting seems a bit odd; _ASM_ALIGN, _ASM_PTR, and .section are functionally equivalent to the opcode field, as is .byte, so the shift in indentation for the .byte lines seems odd at best.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |