[lkml]   [2009]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/5] ext4: Avoid races caused by on-line resizing and SMP memory reordering
    On Tue, Apr 28, 2009 at 06:23:59PM +0200, Jan Kara wrote:
    > Ouch... Hmm, smp_rmb() isn't completely free and mainly it's a bit
    > ugly and prone to errors (I'm afraid next time someone changes the
    > allocation code, we miss some barriers again)... so.. Maybe a stupid
    > idea but wouldn't it be easier to solve the online resize like: freeze
    > the filesystem, do all the changes required for extend, unfreeze the
    > filesystem?

    Eric suggested a helper function when reading from s_groups_count.
    That would take care of the code maintenance headache. One problem
    with using freeze/thaw is it won't work without a journal, and we do
    support filesystems without journals in ext4. (Probably the best
    solution for netbooks with crapola SSD's.)

    As far as smb_rmb() not being free, it's essentially free for
    x86/x86_64 platforms. Is it really that costly on other

    - Ted

     \ /
      Last update: 2009-04-28 19:17    [W:0.020 / U:41.948 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site