lkml.org 
[lkml]   [2009]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/15] ia64: convert to use __HEAD and HEAD_TEXT macros.
On Sat, Apr 25, 2009 at 10:11:01PM -0400, Tim Abbott wrote:
> This has the consequence of changing the section name use for head
> code from ".text.head" to ".head.text". Since this commit changes all
> users in the architecture, this change should be harmless.
>
> Signed-off-by: Tim Abbott <tabbott@mit.edu>
> Cc: Tony Luck <tony.luck@intel.com>
> ---
> arch/ia64/kernel/head.S | 2 +-
> arch/ia64/kernel/vmlinux.lds.S | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/ia64/kernel/head.S b/arch/ia64/kernel/head.S
> index 23f846d..a572160 100644
> --- a/arch/ia64/kernel/head.S
> +++ b/arch/ia64/kernel/head.S
> @@ -181,7 +181,7 @@ swapper_pg_dir:
> halt_msg:
> stringz "Halting kernel\n"
>
> - .section .text.head,"ax"
> + __HEAD
>
> .global start_ap
>
> diff --git a/arch/ia64/kernel/vmlinux.lds.S b/arch/ia64/kernel/vmlinux.lds.S
> index 4a95e86..a8b879e 100644
> --- a/arch/ia64/kernel/vmlinux.lds.S
> +++ b/arch/ia64/kernel/vmlinux.lds.S
> @@ -51,8 +51,8 @@ SECTIONS
> KPROBES_TEXT
> *(.gnu.linkonce.t*)
> }
> - .text.head : AT(ADDR(.text.head) - LOAD_OFFSET)
> - { *(.text.head) }
> + HEAD_TEXT_SECTION : AT(ADDR(HEAD_TEXT_SECTION) - LOAD_OFFSET)
> + { HEAD_TEXT }

1) Spell it out directly rahter than using a macro
2) Consider fixing the style when you are here anyway.
The 'correct' style is to use C rules for '{}' and indent.
But I guess you followed style of the file - which is ok.

Sam


\
 
 \ /
  Last update: 2009-04-26 13:21    [W:0.107 / U:0.964 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site