Messages in this thread | | | From | Roland McGrath <> | Subject | Re: ptrace && cred_exec_mutex (Was: [PATCH] ptrace: tracehook_unsafe_exec: remove the stale comment) | Date | Fri, 24 Apr 2009 12:38:35 -0700 (PDT) |
| |
> (change subject, add more CCs) > > On 04/23, Roland McGrath wrote: > > > > > tracehook_unsafe_exec() doesn't need task_lock(), remove the old comment. > > > > Please make it instead say that cred_exec_mutex is held by the caller > > through the exec. > > Yes. Except it looks like ->cred_exec_mutex is never used in fact. > > ptrace_attach() takes current->cred_exec_mutex ? iow, ptrace and exec > use different locks ?
Good point! That sure looks broken to me. David?
Either that should be task->cred_exec_mutex, or Oleg and I are completely confused about what cred_exec_mutex is meant for.
Thanks, Roland
| |