Messages in this thread | | | Date | Fri, 24 Apr 2009 17:16:41 +0400 | From | Ivan Kokshaysky <> | Subject | Re: [PATCH 1/4] pci/x86: don't assume pref memio are 64bit -v4 |
| |
On Thu, Apr 23, 2009 at 08:48:32PM -0700, Yinghai Lu wrote: > > we should not assign 64bit range to pci device that only take 32bit pref > > try to set IORESOURCE_MEM_64 in 64bit resource of pci_device/pci_bridge > and make the bus resource only have that bit set when all device under that do support > 64bit pref mem then use that flag to allocate resource in wanted area > > v2: fix b_res->flags and logic and passing result. > v3: split iomem to iomem32, iomem64, and iomem64 will take IORESOURCE_MEM_64 > V4: according to Ivan > make it support x86 only, by PCIBIOS_MAX_MEM_32 > double check if the bridge does support pref mem64 with write/read UPPER32
Thanks, Yinghai.
> [Impact: do assign wrong range to device that doesn't support it] > > Reported-by: Yannick <yannick.roehlly@free.fr> > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Reviewed-by: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Ivan.
| |