lkml.org 
[lkml]   [2009]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm/vmalloc.c: fix sparse warning
On Thu, Apr 23, 2009 at 01:23:58PM -0700, Andrew Morton wrote:
> On Fri, 17 Apr 2009 20:55:06 -0400
> "H Hartley Sweeten" <hartleys@visionengravers.com> wrote:
>
> > Fix sparse warning in mm/vmalloc.c.
> >
> > warning: symbol 'tmp' shadows an earlier one

Folks, could we please add to appropriate documentation (SubmittingPatches,
perhaps) a bit about using descriptive subjects?

In general, "$TOOL warning in $FILE" says nothing useful. In this case
"Get rid of shadowed variable in mm/vmalloc.c:<function>" would be far
more useful, with "found by sparse" _maybe_ showing up in the commit
message more or less as a footnote. Or even "shadowed variable in
mm/vmalloc.c:<function>".


\
 
 \ /
  Last update: 2009-04-23 22:39    [W:0.028 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site