Messages in this thread | | | Date | Thu, 23 Apr 2009 08:30:52 -0700 | Subject | Re: [RFC PATCH 1/2] pci: don't assume pref memio are 64bit -v3 | From | Yinghai Lu <> |
| |
On Thu, Apr 23, 2009 at 5:58 AM, Ivan Kokshaysky <ink@jurassic.park.msu.ru> wrote: > On Wed, Apr 22, 2009 at 07:03:33PM -0700, Yinghai Lu wrote: >> to check the BAR support 64bit or not should be read from >> pci_read_bases and pci_bridge_read_bases... > > pci_read_bases: take a closer look at decode_bar() function and > PCI_BASE_ADDRESS_MEM_TYPE_64 flag. > > pci_bridge_read_bases: we cannot rely on the bits 0-3 of > PCI_PREF_MEMORY_BASE providing correct information anyway. > More reliable check for 64-bitness would be a test for > PCI_PREF_BASE_UPPER32 register being r/w, which I think > belongs in pci_bridge_check_ranges().
check bits 0-3 and check PCI_PREF_BASE_UPPER32 register being r/w ?
YH
| |