lkml.org 
[lkml]   [2009]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 096/100] NFS: Fix the XDR iovec calculation in nfs3_xdr_setaclargs
    -stable review patch.  If anyone has any objections, please let us know.
    ---------------------

    From: Trond Myklebust <Trond.Myklebust@netapp.com>

    upstream commit: 8340437210390676f687633a80e3748c40885dc8

    Commit ae46141ff08f1965b17c531b571953c39ce8b9e2 (NFSv3: Fix posix ACL code)
    introduces a bug in the calculation of the XDR header iovec. In the case
    where we are inlining the acls, we need to adjust the length of the iovec
    req->rq_svec, in addition to adjusting the total buffer length.

    Tested-by: Leonardo Chiquitto <leonardo.lists@gmail.com>
    Tested-by: Suresh Jayaraman <sjayaraman@suse.de>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@kernel.org
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    ---
    fs/nfs/nfs3xdr.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/fs/nfs/nfs3xdr.c
    +++ b/fs/nfs/nfs3xdr.c
    @@ -716,7 +716,8 @@ nfs3_xdr_setaclargs(struct rpc_rqst *req
    if (args->npages != 0)
    xdr_encode_pages(buf, args->pages, 0, args->len);
    else
    - req->rq_slen += args->len;
    + req->rq_slen = xdr_adjust_iovec(req->rq_svec,
    + p + XDR_QUADLEN(args->len));

    err = nfsacl_encode(buf, base, args->inode,
    (args->mask & NFS_ACL) ?


    \
     
     \ /
      Last update: 2009-04-23 10:03    [W:0.020 / U:0.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site