[lkml]   [2009]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 18/22] Use allocation flags as an index to the zone watermark
    > On Wed, 2009-04-22 at 18:14 +0100, Mel Gorman wrote:
    > > Preference of taste really. When I started a conversion to accessors, it
    > > changed something recognised to something new that looked uglier to me.
    > > Only one place cares about the union enough to access is via an array so
    > > why spread it everywhere.
    > Personally, I'd say for consistency. Someone looking at both forms
    > wouldn't necessarily know that they refer to the same variables unless
    > they know about the union.

    for just clalification...

    AFAIK, C language specification don't gurantee point same value.
    compiler can insert pad between struct-member and member, but not insert
    into array.

    However, all gcc version don't do that. I think. but perhaps I missed
    some minor gcc release..

    So, I also like Dave's idea. but it only personal feeling.

     \ /
      Last update: 2009-04-23 02:29    [W:0.022 / U:1.120 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site