Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 18/22] Use allocation flags as an index to the zone watermark | Date | Thu, 23 Apr 2009 09:27:15 +0900 (JST) |
| |
> On Wed, 2009-04-22 at 18:14 +0100, Mel Gorman wrote: > > Preference of taste really. When I started a conversion to accessors, it > > changed something recognised to something new that looked uglier to me. > > Only one place cares about the union enough to access is via an array so > > why spread it everywhere. > > Personally, I'd say for consistency. Someone looking at both forms > wouldn't necessarily know that they refer to the same variables unless > they know about the union.
for just clalification...
AFAIK, C language specification don't gurantee point same value. compiler can insert pad between struct-member and member, but not insert into array.
However, all gcc version don't do that. I think. but perhaps I missed some minor gcc release..
So, I also like Dave's idea. but it only personal feeling.
| |