lkml.org 
[lkml]   [2009]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] include/linux/pktcdvd.h: add mempool.h dependency

* Jens Axboe <jens.axboe@oracle.com> wrote:

> On Wed, Apr 22 2009, Ingo Molnar wrote:
> >
> > * Ingo Molnar <mingo@elte.hu> wrote:
> >
> > > A last-minute build error slipped through:
> > >
> > > In file included from fs/compat_ioctl.c:105:
> > > include/linux/pktcdvd.h:285: error: expected specifier-qualifier-list before ???mempool_t???
> >
> > Caused by:
> >
> > 1ba0c7d: fs/compat_ioctl: fix build when !BLOCK
> >
> > fixed by the patch below. The build error itself triggers with
> > !BLOCK
>
> This fix is already queued up in the block tree, it just didn't
> make -rc3.

ah, i see - it was posted two days ago:

[PATCH 2/2] pktcdvd.h should include mempool.h

but the fix should have been queued up in the tree pushing the
compat_ioctl.c change (Viro's). Could have been avoided by insisting
on a fuller explanation in the changelog instead of just a "Fix this
build error" line.

Ingo


\
 
 \ /
  Last update: 2009-04-22 08:57    [W:0.045 / U:4.344 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site