lkml.org 
[lkml]   [2009]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH] usb/core/hub.c: fix sparse warnings
Date
From
On Tuesday, April 21, 2009 10:51 PM, Greg KH wrote:
> On Wed, Apr 15, 2009 at 09:44:44PM -0400, H Hartley Sweeten wrote:
>> Fix sparse warning in drivers/usb/core/hub.c.
>>
>> warning: symbol 'temp' shadows an earlier one
>
> Odd, I'm not seeing that when I run sparse on this file. What
> version of sparse are you using?

Not sure about the sparse version. I obtained the most recent version
with git on 15 Apr 2009.

I just rechecked the original file and I do see the warning.

CHECK drivers/usb/core/hub.c
drivers/usb/core/hub.c:472:3: warning: symbol 'temp' shadows an earlier
One drivers/usb/core/hub.c:460:20: originally declared here

This was found on a EP93xx ARM platform. It appears the sparse warning
is caused by the raw_local_irq_save() macro in
arch/arm/include/asm/irqflags.h.

> Also, the patch is line-wrapped and you delete a lot of trailing
> spaces. Deleting trailing spaces is nice, but that's not what you
> said you were doing here in this patch, so I'm going to have to
> drop it.

Sorry about the line-wrapping. I'm still trying to work that out.

I noticed the trailing spaces getting fixed in the patch. I didn't
know I had to mention that in the patch description. Again sorry.

> thanks,
>
> greg k-h

Regards,
Hartley


\
 
 \ /
  Last update: 2009-04-22 19:29    [W:0.853 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site