lkml.org 
[lkml]   [2009]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] include/linux/pktcdvd.h: add mempool.h dependency
    On Wed, Apr 22 2009, Ingo Molnar wrote:
    >
    > * Ingo Molnar <mingo@elte.hu> wrote:
    >
    > > A last-minute build error slipped through:
    > >
    > > In file included from fs/compat_ioctl.c:105:
    > > include/linux/pktcdvd.h:285: error: expected specifier-qualifier-list before ???mempool_t???
    >
    > Caused by:
    >
    > 1ba0c7d: fs/compat_ioctl: fix build when !BLOCK
    >
    > fixed by the patch below. The build error itself triggers with
    > !BLOCK

    This fix is already queued up in the block tree, it just didn't make
    -rc3.

    >
    > Ingo
    >
    > ------------------>
    > From f8b664b0e6ad3369a998379e7f87297082d04bef Mon Sep 17 00:00:00 2001
    > From: Ingo Molnar <mingo@elte.hu>
    > Date: Wed, 22 Apr 2009 08:29:40 +0200
    > Subject: [PATCH] include/linux/pktcdvd.h: add mempool.h dependency
    > MIME-Version: 1.0
    > Content-Type: text/plain; charset=utf-8
    > Content-Transfer-Encoding: 8bit
    >
    > A change to the order of header files in fs/compat_ioctl.c
    > unearthed a dormant header file dependency bug:
    >
    > In file included from fs/compat_ioctl.c:105:
    > include/linux/pktcdvd.h:285: error: expected specifier-qualifier-list before ???mempool_t???
    >
    > pktcdvd.h relies on mempool_t but does not include mempool.h.
    > This worked until now accidentally: due to other headers including
    > mempool.h in compat_ioctl.c (and all other pktcdvd.h using sites).
    > But once the header file broke this implicit dependency got
    > uncovered and an uncleanliness turned into a build failure.
    >
    > Add mempool.h to pktcdvd.h.
    >
    > [ Impact: fix build on !CONFIG_BLOCK ]
    >
    > Signed-off-by: Ingo Molnar <mingo@elte.hu>
    > ---
    > include/linux/pktcdvd.h | 1 +
    > 1 files changed, 1 insertions(+), 0 deletions(-)
    >
    > diff --git a/include/linux/pktcdvd.h b/include/linux/pktcdvd.h
    > index 04b4d73..9cabc20 100644
    > --- a/include/linux/pktcdvd.h
    > +++ b/include/linux/pktcdvd.h
    > @@ -112,6 +112,7 @@ struct pkt_ctrl_command {
    > #include <linux/completion.h>
    > #include <linux/cdrom.h>
    > #include <linux/kobject.h>
    > +#include <linux/mempool.h>
    > #include <linux/sysfs.h>
    >
    > /* default bio write queue congestion marks */
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/

    --
    Jens Axboe



    \
     
     \ /
      Last update: 2009-04-22 08:43    [W:0.024 / U:62.384 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site