| From | KOSAKI Motohiro <> | Subject | Re: [PATCH 16/25] Save text by reducing call sites of __rmqueue() | Date | Tue, 21 Apr 2009 19:47:40 +0900 (JST) |
| |
> } else { > - spin_lock_irqsave(&zone->lock, flags); > - page = __rmqueue(zone, order, migratetype); > - spin_unlock(&zone->lock); > - if (!page) > + LIST_HEAD(list); > + local_irq_save(flags); > + > + /* Calling __rmqueue would bloat text, hence this */ > + if (!rmqueue_bulk(zone, order, 1, &list, migratetype)) > goto failed; > + page = list_entry(list.next, struct page, lru); > + list_del(&page->lru); > }
looks good Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
|