Messages in this thread | | | Date | Tue, 21 Apr 2009 11:11:15 +0100 | From | Mel Gorman <> | Subject | Re: [PATCH 13/25] Inline __rmqueue_smallest() |
| |
On Tue, Apr 21, 2009 at 06:52:28PM +0900, KOSAKI Motohiro wrote: > > Inline __rmqueue_smallest by altering flow very slightly so that there > > is only one call site. This allows the function to be inlined without > > additional text bloat. > > > > Signed-off-by: Mel Gorman <mel@csn.ul.ie> > > Reviewed-by: Christoph Lameter <cl@linux-foundation.org> > > --- > > mm/page_alloc.c | 23 ++++++++++++++++++----- > > 1 files changed, 18 insertions(+), 5 deletions(-) > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index b13fc29..91a2cdb 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -665,7 +665,8 @@ static int prep_new_page(struct page *page, int order, gfp_t gfp_flags) > > * Go through the free lists for the given migratetype and remove > > * the smallest available page from the freelists > > */ > > -static struct page *__rmqueue_smallest(struct zone *zone, unsigned int order, > > +static inline > > +struct page *__rmqueue_smallest(struct zone *zone, unsigned int order, > > int migratetype) > > "only one caller" is one of keypoint of this patch, I think. > so, commenting is better? but it isn't blocking reason at all. > > Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> >
Is this better?
Inline __rmqueue_smallest by altering flow very slightly so that there is only one call site. Because there is only one call-site, this function can then be inlined without causing text bloat.
I don't see a need to add a comment into the function itself as I don't think it would help any.
-- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab
| |