lkml.org 
[lkml]   [2009]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch 3/3][rfc] vmscan: batched swap slot allocation
Date
> On Tue, Apr 21, 2009 at 06:27:08PM +0900, KOSAKI Motohiro wrote:
> > > > > - cond_resched();
> > > > > + if (list_empty(&swap_pages))
> > > > > + cond_resched();
> > > > >
> > > > Why this ?
> > >
> > > It shouldn't schedule anymore when it's allocated the first swap slot.
> > > Another reclaimer could e.g. sleep on the cond_resched() before the
> > > loop and when we schedule while having swap slots allocated, we might
> > > continue further allocations multiple slots ahead.
> >
> > Oops, It seems regression. this cond_resched() intent to
> >
> > cond_resched();
> > pageout();
> > cond_resched();
> > pageout();
> > cond_resched();
> > pageout();
>
> It still does that. While it collects swap pages (swap_pages list is
> non-empty), it doesn't page out. And if it restarts for unmap and
> page-out, the swap_pages list is empty and cond_resched() is called.

Ah, ok.




\
 
 \ /
  Last update: 2009-04-21 11:43    [W:0.887 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site