Messages in this thread | | | Date | Mon, 20 Apr 2009 10:47:47 +0200 | From | Andreas Herrmann <> | Subject | Re: [PATCH] pci: derive nearby CPUs from device's instead of bus' NUMA information |
| |
On Fri, Apr 17, 2009 at 12:26:54PM -0700, Yinghai Lu wrote: > On Fri, Apr 17, 2009 at 9:21 AM, Ingo Molnar <mingo@elte.hu> wrote: > > const struct cpumask * cpumask_of_pcidev(struct pci_dev *dev) > > { > > if (dev->numa_node == -1) > > return cpumask_of_pcibus(to_pci_dev(dev)->bus); > > > > return cpumask_of_node(dev_to_node(dev)); > > } > > > > ? This would work fine in all cases.
Yes, I think so. That's the general solution w/o additional "ifdefing".
> you are right, dev_to_node(dev) could return -1 on 64bit, if there is > no memory on that node.
Hmm, I thought just in the CONFIG_NUMA=n case -1 is returned.
During initialization the struct device's numa_node is set to -1 and later on the information is inherited from the parent numa_node.
So what do I miss?
Thanks, Andreas
-- Operating | Advanced Micro Devices GmbH System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany Research | Geschäftsführer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München (OSRC) | Registergericht München, HRB Nr. 43632
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |