lkml.org 
[lkml]   [2009]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] tracing: use nowakeup version of commit for function event trace tests

On Tue, 21 Apr 2009, Frederic Weisbecker wrote:

> On Mon, Apr 20, 2009 at 06:22:59PM -0400, Steven Rostedt wrote:
> > From: Steven Rostedt <srostedt@redhat.com>
> >
> > The startup tests for the event tracer also runs with the function
> > tracer enabled. The "wakeup" version of the trace commit was used
> > which can grab spinlocks. If a task was preempted by an NMI
> > that called a function being traced, it could deadlock due to the
> > function tracer trying to grab the same lock.
> >
> > Thanks to Frederic Weisbecker for pointing out where the bug was.
> >
> > Reported-by: Ingo Molnar <mingo@elte.hu>
> > Reported-by: Frederic Weisbecker <fweisbec@gmail.com>
> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> > ---
>
>
> Aah, I was about to push my version, which was the same but with
> a more weird changelog :-)
>

I was going to let you post it, but since I was the one to write the bug,
and it was a one-liner, and I was hitting it myself, I decided to push it.
Otherwise I might have seen your patch's signature section:

fixed-code-f*cked-up-by: Steven Rostedt

/me was reading the conversation on IRC ;-)

-- Steve



\
 
 \ /
  Last update: 2009-04-21 00:59    [W:0.684 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site