| From | Mel Gorman <> | Subject | [PATCH 23/25] Get the pageblock migratetype without disabling interrupts | Date | Mon, 20 Apr 2009 23:20:09 +0100 |
| |
Local interrupts are disabled when freeing pages to the PCP list. Part of that free checks what the migratetype of the pageblock the page is in but it checks this with interrupts disabled. This patch checks the pagetype with interrupts enabled. The impact is that it is possible a page is freed to the wrong list when a pageblock changes type but as that block is now already considered mixed from an anti-fragmentation perspective, it's not of vital importance.
Signed-off-by: Mel Gorman <mel@csn.ul.ie> --- mm/page_alloc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 6bcaf08..acb0fac 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1035,6 +1035,7 @@ static void free_hot_cold_page(struct page *page, int cold) kernel_map_pages(page, 1, 0); pcp = &zone_pcp(zone, get_cpu())->pcp; + set_page_private(page, get_pageblock_migratetype(page)); local_irq_save(flags); if (unlikely(clearMlocked)) free_page_mlock(page); @@ -1044,7 +1045,6 @@ static void free_hot_cold_page(struct page *page, int cold) list_add_tail(&page->lru, &pcp->list); else list_add(&page->lru, &pcp->list); - set_page_private(page, get_pageblock_migratetype(page)); pcp->count++; if (pcp->count >= pcp->high) { free_pages_bulk(zone, pcp->batch, &pcp->list, 0); -- 1.5.6.5
|