lkml.org 
[lkml]   [2009]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing: mark get_parent_ip() notrace
On Thu, Apr 02, 2009 at 02:18:25PM +0800, Lai Jiangshan wrote:
>
> Impact: remove redundancy tracing log
>
> When tracer is "function" or "function_graph", too much
> "get_parent_ip" are recorded in ring_buffer.


Thanks, indeed this get_parent_ip was a bit harrassing
in the traces, though I still don't understand why it is
called so often.

Anyway, tracing it seems to me not useful.

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>



> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/kernel/sched.c b/kernel/sched.c
> index 706517c..a0ec10c 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -4860,7 +4860,7 @@ void scheduler_tick(void)
> #endif
> }
>
> -unsigned long get_parent_ip(unsigned long addr)
> +notrace unsigned long get_parent_ip(unsigned long addr)
> {
> if (in_lock_functions(addr)) {
> addr = CALLER_ADDR2;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/



\
 
 \ /
  Last update: 2009-04-02 14:29    [W:0.083 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site