lkml.org 
[lkml]   [2009]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:x86/urgent] x86: Fix false positive section mismatch warnings in the apic code

* Marcin Slusarz <marcin.slusarz@gmail.com> wrote:

> tip-bot for Rakib Mullick pisze:
> > Commit-ID: aa57a15ad17d284e62fbd24cf7e0eb628b2cb3f7
> > Gitweb: http://git.kernel.org/tip/aa57a15ad17d284e62fbd24cf7e0eb628b2cb3f7
> > Author: Rakib Mullick <rakib.mullick@gmail.com>
> > AuthorDate: Sun, 19 Apr 2009 08:41:17 +0600
> > Committer: Ingo Molnar <mingo@elte.hu>
> > CommitDate: Sun, 19 Apr 2009 11:28:18 +0200
> >
> > x86: Fix false positive section mismatch warnings in the apic code
> >
> > find_unisys_acpi_oem_table() and unmap_unisys_acpi_oem_table()
> > are non init functions, but these functions calls some init
> > functions. But we need these functions as non-init functions.
>
> Why? This warning seems to be valid.

It's put into struct apic::acpi_madt_oem_check - which is a non-init
structure. That particular field is only used from init context -
but other fields are used all the time.

Sam, what's the preferred way to handle these? We could mark the
function pointer prototype there as __initdata, but i suspect we'll
still get the warning in that case.

Ingo


\
 
 \ /
  Last update: 2009-04-19 12:01    [W:0.773 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site